Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Upgrade pinpoint-profiler to 3.x.x #4963

Closed
2 of 3 tasks
Pil0tXia opened this issue Jun 3, 2024 · 2 comments · Fixed by #5010
Closed
2 of 3 tasks

[Enhancement] Upgrade pinpoint-profiler to 3.x.x #4963

Pil0tXia opened this issue Jun 3, 2024 · 2 comments · Fixed by #5010
Assignees
@lmnewton
Labels
enhancement New feature or request good first issue Issues for first-time contributors

Comments

@Pil0tXia
Copy link
Member

Pil0tXia commented Jun 3, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

Dependabot failed to upgrade com.navercorp.pinpoint:pinpoint-profiler from 2.4.1 to 2.5.4 in #4961. The build failed because there are references to DefaultTraceRoot which has been removed.

Describe the solution you'd like

Update deprecated usages. Upgrade to v3 if possible.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@Pil0tXia Pil0tXia added enhancement New feature or request good first issue Issues for first-time contributors labels Jun 3, 2024
@Pil0tXia Pil0tXia mentioned this issue Jun 3, 2024
Open
@lmnewton
Copy link
Contributor

lmnewton commented Jun 3, 2024

Hi @Pil0tXia , could I take a look at this issue?

@Pil0tXia
Copy link
Member Author

Pil0tXia commented Jun 3, 2024

@lmnewton Of course. Welcome to Apache EventMesh community!

@Pil0tXia Pil0tXia mentioned this issue Jun 17, 2024
Closed
@lmnewton lmnewton mentioned this issue Jun 24, 2024
Merged
Pil0tXia pushed a commit that referenced this issue Jul 11, 2024
@lmnewton
[ISSUE #4963] Updating version of pinpoint libraries to 3.0.0 (#5010)
015b6e9 
* Upgrading version of pinpoint-profiler to 3.0

Signed-off-by: lmnewton <lindsay.marie.newton@gmail.com>

* Fixing issues with how transaction IDs are being passed, added test to test that parent context is being propagated.

* Addressing checkstyle violations.

Signed-off-by: Lindsay Newton <lindsay.marie.newton@gmail.com>

* Fixing import ordering issue for checkstyle.

Signed-off-by: Lindsay Newton <lindsay.marie.newton@gmail.com>

---------

Signed-off-by: lmnewton <lindsay.marie.newton@gmail.com>
Signed-off-by: Lindsay Newton <lindsay.marie.newton@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmnewton lmnewton

Labels
enhancement New feature or request good first issue Issues for first-time contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #4963] Updating version of pinpoint libraries to 3.0.0 lmnewton/eventmesh
2 participants
@lmnewton @Pil0tXia