Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-27502] Add file Suffix to data files #133

Merged
merged 3 commits into from Jun 8, 2022
Merged

[FLINK-27502] Add file Suffix to data files #133

merged 3 commits into from Jun 8, 2022

Conversation

hililiwei
Copy link
Contributor

@hililiwei hililiwei commented May 20, 2022 •
edited

What is the purpose of the change

Add file Suffix to data files, close FLINK-27502

Verifying this change

org.apache.flink.table.store.format.FileFormatSuffixTest

@JingsongLi JingsongLi self-requested a review May 22, 2022 03:13
JingsongLi
JingsongLi reviewed May 22, 2022
View reviewed changes
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hililiwei for the contribution! Looks nice~ I left some comments.

flink-table-store-format/pom.xml Outdated Show resolved Hide resolved
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/format/FileFormat.java Outdated Show resolved Hide resolved
...ble-store-core/src/main/java/org/apache/flink/table/store/file/data/DataFilePathFactory.java Outdated Show resolved Hide resolved
@hililiwei hililiwei requested a review from JingsongLi May 26, 2022 12:34
@hililiwei
Copy link
Contributor Author

Thanks @hililiwei for the contribution! Looks nice~ I left some comments.

thank you for review, PTAL.

JingsongLi
JingsongLi reviewed May 27, 2022
View reviewed changes
...e-store-core/src/main/java/org/apache/flink/table/store/file/utils/FileStorePathFactory.java Outdated
return createDataFilePathFactory(partition, bucket, formatIdentifier);
}

public DataFilePathFactory createDataFilePathFactory(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why introduce this method? There is a formatIdentifier in here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I submitted the wrong one. Has been updated.

@JingsongLi
Copy link
Contributor

You can run a mvn spotless:apply after modification.

@hililiwei hililiwei force-pushed the FLINK-27502 branch 4 times, most recently from c92fee0 to d31ed31 Compare May 27, 2022 04:30
@hililiwei hililiwei marked this pull request as draft May 27, 2022 04:44
@hililiwei hililiwei marked this pull request as ready for review May 27, 2022 05:02
@hililiwei hililiwei requested a review from JingsongLi May 27, 2022 05:03
@hililiwei
Copy link
Contributor Author

You can run a mvn spotless:apply after modification.

done.

@JingsongLi
Copy link
Contributor 

Error:  Failures: 
Error:    DataFilePathFactoryTest.testNoPartition:46 
expected: /tmp/junit13044672734532131/bucket-123/data-de33b78b-2802-49a0-8ec7-cbeeed7af049-0
 but was: /tmp/junit13044672734532131/bucket-123/data-de33b78b-2802-49a0-8ec7-cbeeed7af049-0.orc
Error:    DataFilePathFactoryTest.testWithPartition:64 
expected: /tmp/junit3939205851475787579/dt=20211224/bucket-123/data-8a204f50-ad09-4e55-a41f-39c94da0863c-0
 but was: /tmp/junit3939205851475787579/dt=20211224/bucket-123/data-8a204f50-ad09-4e55-a41f-39c94da0863c-0.orc
[INFO]

Test failure, you need to adjust some testing codes too.

@hililiwei
Copy link
Contributor Author

Updated and passed the fork repo CI. Please let it run again, i will see if there are any other mistakes. @JingsongLi

JingsongLi
JingsongLi approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for your contribution!

@JingsongLi JingsongLi merged commit b7f4793 into apache:master Jun 8, 2022
@hililiwei
Copy link
Contributor Author

thanks for review.

@hililiwei hililiwei deleted the FLINK-27502 branch June 8, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JingsongLi JingsongLi JingsongLi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hililiwei @JingsongLi