Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-29916] Fix bug that Levels in Table Store may mistakenly ignore level 0 files when two files have the same sequence number #363

Merged
merged 1 commit into from Nov 8, 2022

Conversation

tsreaper
Copy link
Contributor

@tsreaper tsreaper commented Nov 8, 2022

(Cherry-picked from #356)

Current constructor of Levels class contains the following code:

this.level0 = new TreeSet<>(Comparator.comparing(DataFileMeta::maxSequenceNumber).reversed());

However when two or more jobs writing the same bucket, they may produce files containing the same sequence number. If two files have the same maxSequenceNumber, one of them will be mistakenly ignored by TreeSet.

…e level 0 files when two files have the same sequence number
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@tsreaper tsreaper merged commit 1c66dbf into apache:release-0.2 Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants