Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-25644] Introduce interfaces between file-table-store and flink connector sink #9

Merged
merged 3 commits into from
Jan 17, 2022
Merged

[FLINK-25644] Introduce interfaces between file-table-store and flink connector sink #9

merged 3 commits into from
Jan 17, 2022

Conversation

JingsongLi
Copy link
Contributor

We should introduce a FileStore interface to provide operations:

  • provides FileStoreWrite: Write operation which provides RecordWriter creation.
  • provides FileStoreCommit: Commit operation which provides commit and overwrite.
  • provides FileStoreExpire: Expire operation which provides snapshots expire.

tsreaper
tsreaper reviewed Jan 17, 2022
View reviewed changes
Copy link
Contributor

@tsreaper tsreaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about FileStoreScan? We will need to read all ManifestEntry when checking for conflicts before committing.

@JingsongLi JingsongLi merged commit e1ce970 into apache:master Jan 17, 2022
@JingsongLi JingsongLi deleted the sink_interface branch February 14, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsreaper tsreaper tsreaper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JingsongLi @tsreaper