FLINK-30454 [runtime] Fixing visibility issue for SizeGauge.SizeSupplier #21531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changing visibility JsonJobResultEntry.FIELD_NAME_VERSION as per JLS§6.6.1 requirements.
|
// CC @rmetzger |
rmetzger
reviewed
Dec 20, 2022
| @@ -207,7 +207,7 @@ public Set<JobResult> getDirtyResultsInternal() throws IOException { | |||
| @VisibleForTesting | |||
| static class JsonJobResultEntry extends JobResultEntry { | |||
| private static final String FIELD_NAME_RESULT = "result"; | |||
| private static final String FIELD_NAME_VERSION = "version"; | |||
| static final String FIELD_NAME_VERSION = "version"; | |||
There was a problem hiding this comment.
What's the purpose of this change?
There was a problem hiding this comment.
The field couldn't be referenced in the annotation otherwise when compiling with ecj. I suppose it's another case where javac is a bit too lenient.
rmetzger
approved these changes
Dec 21, 2022
|
I'm manually merging this PR, adjusting the commit message to adhere to the Flink pattern |
chucheng92
pushed a commit
to chucheng92/flink
that referenced
this pull request
Feb 3, 2023
Also changing visibility JsonJobResultEntry.FIELD_NAME_VERSION as per JLS§6.6.1 requirements. This closes apache#21531
akkinenivijay
pushed a commit
to krisnaru/flink
that referenced
this pull request
Feb 11, 2023
Also changing visibility JsonJobResultEntry.FIELD_NAME_VERSION as per JLS§6.6.1 requirements. This closes apache#21531
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/FLINK-30454
What is the purpose of the change
Making sure the runtime module can be compiled with ecj. I encountered two locations which seem inconsistent with the JLS but were still accepted by javac.
Brief change log
Reworked two code places to make it compile with ecj. Note the change around
SizeGauge.SizeSupplieris source-compatible but not binary-compatible, based on the assumption that this code is not invoked in external client code. If that actually is the case, I'd rework the change to simply change the visibility ofSizeGaugeto public.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation