FLUME-3152 Add Flume Metric for Backup Checkpoint Errors #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaboferee
force-pushed
the
FLUME-3152
branch
2 times, most recently
from
d16d628
to
e6b3723
Compare
adenes
suggested changes
Aug 23, 2017
There was a problem hiding this comment.
Hi @szaboferee, thank you for the patch. All in all it looks good to me, I have only one comment: could you please add a more "extended" test? Like the ones for the other error counters.
Thanks.
Change-Id: I525e4be2d0f95f50e4fa2307fc225a4faaab5aec
|
@szaboferee , thanks for the added test case. |
mcsanady
pushed a commit
to mcsanady/flume
that referenced
this pull request
Mar 13, 2018
This change adds a new metric (channel.file.checkpoint.backup.write.error) to the File Channel. It gets incremented if an exception happens during backup checkpoints writes. This closes apache#156 Reviewers: Denes Arvay (Ferenc Szabo via Denes Arvay) Change-Id: Iba6f142e8cbd8f4ec6a357efaf7a7b0aa6867e1d
waidr
pushed a commit
to waidr/flume
that referenced
this pull request
Jul 24, 2019
update codec profile classification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new metric to the file channel
new test case added
build with tests was successful