FLUME-3190: flume shutdown hook issue when both hbase and hdfs sink a… #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mcsanady, Thanks for your contribution. I have some questions: Thanks, |
|
Please ask @adenes, he continues all my works at Cloudera. |
|
Can one of the admins verify this patch? |
waidr
pushed a commit
to waidr/flume
that referenced
this pull request
Jul 24, 2019
add week of granule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When both hdfs and hbase sink are in use, during shutdown (KILL SIGTERM), the hdfs sink won't be able to rename/close the .tmp hdfs file because the underlying filesystem could be closed earlier when shutting down the other component.
This change registers a new ShutdownHook in the hadoop's ShutdownHookManager, which will prevent other hooks to run until Flume stops itself.
Tested on a cluster which could reproduce the error before the change, but eliminated after.