Add Developer Section / How to Commit from cwiki.apache.org #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bessbd
commented
Oct 25, 2016
|
|
||
| ``` | ||
| Flume-XXX. Brief description of the problem. | ||
|
|
There was a problem hiding this comment.
Maybe we should add the "Reviewers:" line here (and "This closes #x") if it's a pull request.
simonati
reviewed
Oct 27, 2016
There was a problem hiding this comment.
Missing section :"This guide highlights the process and responsibilities of committers on Flume project. Note: Just like contributors, committers must follow the same guidelines for contributions as highlighted in the How to Contribute guide."
I checked content, links, formatting against existing cwiki. TOC is missing but seems like it is down to github isaacs/github#215
Otherwise looks good to me.
|
Thank you, @satiatcloudera Good catch! |
|
I'm about to commit this. |
mcsanady
pushed a commit
to mcsanady/flume
that referenced
this pull request
Mar 13, 2018
Reviewers: Attila Simon This closes apache#80 Change-Id: Ife26c86a14143994469799eb2e967560fe0daaca
waidr
pushed a commit
to waidr/flume
that referenced
this pull request
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.