HDDS-3821. Disable Ozone SPNEGO should not fall back to hadoop.http.a… #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
org.apache.hadoop.ozone.client.rpc.Test2WayCommitInRatis seems to be flaky. Pass in the first commit but not the second one. |
dineshchitlangia
approved these changes
Jun 24, 2020
|
@xiaoyuyao Thanks for working on this and @dineshchitlangia for reviewing it! |
errose28
pushed a commit
to errose28/ozone
that referenced
this pull request
Jun 25, 2020
* upstream/master: (56 commits) HDDS-3264. Fix TestCSMMetrics.java. (apache#1120) HDDS-3858. Remove support to start Ozone and HDFS datanodes in the same JVM (apache#1117) HDDS-3704. Update all the documentation to use ozonefs-hadoop2/3 instead of legacy/current (apache#1099) HDDS-3773. Add OMDBDefinition to define structure of om.db. (apache#1076) Revert "HDDS-3263. Fix TestCloseContainerByPipeline.java. (apache#1119)" (apache#1126) HDDS-3821. Disable Ozone SPNEGO should not fall back to hadoop.http.a… (apache#1101) HDDS-3819. OzoneManager#listVolumeByUser ignores userName parameter when ACL is enabled (apache#1087) HDDS-3779. Add csi interface documents to show how to use ozone csi (apache#1059) HDDS-3857. Datanode in compose/ozonescripts can't be started (apache#1116) HDDS-3430. Enable TestWatchForCommit test cases. (apache#1114) HDDS-3263. Fix TestCloseContainerByPipeline.java. (apache#1119) HDDS-3512. s3g multi-part-upload saved incorrect content using streaming (apache#1092) HDDS-3836. Modify ContainerPlacementPolicyFactory JavaDoc (apache#1097) HDDS-3780. Replace the imagePullPolicy from always to IfNotPresent (apache#1055) HDDS-3847. Change OMNotLeaderException logging to DEBUG (apache#1118) HDDS-3745. Improve OM and SCM performance with 64% by avoid collect datanode information to s3g (apache#1031) HDDS-3286. BasicOzoneFileSystem support batchDelete. (apache#814) HDDS-3850. Update the admin document to let user know how to show the status of all rules. (apache#1109) HDDS-3848. Add ratis.thirdparty.version in main pom.xml (apache#1108) HDDS-3815. Avoid buffer copy in ContainerCommandRequestProto. (apache#1085) ...
adoroszlai
reviewed
Jul 15, 2020
Comment on lines
+23
to
+24
| log4j.logger.org.apache.ratis.grpc.server.GrpcLogAppender=DEBUG | ||
| log4j.logger.org.apache.ratis.server.impl.RaftServerImpl=DEBUG |
There was a problem hiding this comment.
Hi @xiaoyuyao,
Were these Ratis log levels intentionally set to DEBUG in the final commit, or is it a leftover that should have been removed?
|
This should be removed. Thanks @adoroszlai
…On Wed, Jul 15, 2020 at 5:40 AM Doroszlai, Attila ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In hadoop-ozone/integration-test/src/test/resources/log4j.properties
<#1101 (comment)>:
> +log4j.logger.org.apache.ratis.grpc.server.GrpcLogAppender=DEBUG
+log4j.logger.org.apache.ratis.server.impl.RaftServerImpl=DEBUG
Hi @xiaoyuyao <https://github.com/xiaoyuyao>,
Were these Ratis log levels intentionally set to DEBUG in the final
commit, or is it a leftover that should have been removed?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1101 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVWRUHCRB3AMJLBUVLX7H3R3WPU5ANCNFSM4ODFYWVA>
.
|
Thanks for the confirmation. Created HDDS-3967 for this. Will submit PR soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uthentication configuration.
What changes were proposed in this pull request?
When ozone http kerberos is disabled, ensure the authentication filter does not fallback to configuration from hadoop.http.authentication.*
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3821
How was this patch tested?
Acceptance test and Manual test when ozone http kerberos is disabled but hadoop.http.authentication.* is enabled.