Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDDS-3908. Duplicate dot in Prometheus endpoint config name #1155

Merged
merged 2 commits into from Jul 1, 2020
Merged

HDDS-3908. Duplicate dot in Prometheus endpoint config name #1155

merged 2 commits into from Jul 1, 2020

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Remove trailing dot from config prefix for hdds.prometheus. I think this should be done before 0.6.0 release.

https://issues.apache.org/jira/browse/HDDS-3908

How was this patch tested?

$ mvn -DskipTests clean package
$ grep hdds.prometheus hadoop-hdds/common/target/classes/ozone-default-generated.xml
    <name>hdds.prometheus.endpoint.token</name>

@adoroszlai adoroszlai self-assigned this Jul 1, 2020
avijayanhwx
avijayanhwx approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@avijayanhwx avijayanhwx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @adoroszlai.

vivekratnavel
vivekratnavel approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@vivekratnavel vivekratnavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@vivekratnavel vivekratnavel merged commit c890901 into apache:master Jul 1, 2020
@vivekratnavel
Copy link
Contributor

Thanks @adoroszlai for the patch and @avijayanhwx for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivekratnavel vivekratnavel vivekratnavel approved these changes

@avijayanhwx avijayanhwx avijayanhwx approved these changes

@elek elek Awaiting requested review from elek

Assignees

@adoroszlai adoroszlai

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@adoroszlai @vivekratnavel @avijayanhwx