Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-3879. Introduce SCM and OM layoutVersion zero to the VERSION file #1156

Merged
merged 1 commit into from Jul 9, 2020

Conversation

sodonnel
Copy link
Contributor

@sodonnel sodonnel commented Jul 1, 2020

What changes were proposed in this pull request?

When SCM or OM is initialized, ensure a property like the following is written to the version file:

layoutVersion=0

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-3879

How was this patch tested?

Manually inspected the version file after the change.

@sodonnel
Copy link
Contributor Author

sodonnel commented Jul 1, 2020

@avijayanhwx Is this the sort of change you were intending with this Jira? Note that I think it also covers HDDS-3830 too, as both OM and SCM use the same code from reading and writing the VERSION file.

@avijayanhwx
Copy link
Contributor

@sodonnel Thanks for working on this. I am OK with this change. In the future, we may also have to track a different version number which denotes software version. But, for now, this is OK with me.

@swagle
Copy link
Contributor

swagle commented Jul 7, 2020

@sodonnel Thanks for working on this. I am OK with this change. In the future, we may also have to track a different version number which denotes software version. But, for now, this is OK with me.

@avijayanhwx Shouldn't we add whatever we think would be needed now? Introducing it later will not cause incompat?

@sodonnel
Copy link
Contributor Author

sodonnel commented Jul 7, 2020

I started on the changes to add in the software version too, but in doing that I starting to think about whether we need to actually store it.

I will discuss with @avijayanhwx and see what conclusion we come to. If we need it, we may as well get it in as part of this change.

@avijayanhwx
Copy link
Contributor

I started on the changes to add in the software version too, but in doing that I starting to think about whether we need to actually store it.

I will discuss with @avijayanhwx and see what conclusion we come to. If we need it, we may as well get it in as part of this change.

Yes, this change as it is can go in.

@swagle We will not have any backward compat issues with respect to layout/software version since the default behavior can handle that.

@avijayanhwx
Copy link
Contributor

LGTM +1

@sodonnel sodonnel merged commit f7a0d07 into apache:master Jul 9, 2020
ChenSammi pushed a commit that referenced this pull request Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants