HDDS-3969. Add validName check for FileSystem requests #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avijayanhwx
approved these changes
Jul 17, 2020
| String key = path.toUri().getPath(); | ||
|
|
||
| if (OzoneFSUtils.isValidName(key)) { | ||
| key = path.toUri().getPath().substring(1); |
There was a problem hiding this comment.
Can we just do this here, instead of toUri().getPath() again?
LOG.trace("path for key:{} is:{}", key, path); return key.substring(1);
timmylicheng
pushed a commit
that referenced
this pull request
Aug 6, 2020
rakeshadr
pushed a commit
to rakeshadr/hadoop-ozone
that referenced
this pull request
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This Jira is to validate KeyNames which are created with OzoneFileSystem.
Similar to how hdfs handles using DFSUtil. isValidName()
Made only changes in the client.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3969
How was this patch tested?
Added tests.