Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-3810. Add the logic to distribute open containers among the pipelines of a datanode. #1274

Merged
merged 14 commits into from Oct 5, 2020

Conversation

bshashikant
Copy link
Contributor

What changes were proposed in this pull request?

Added logic for open container distribution among multiple pipelines of a dn

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-3810

How was this patch tested?

Added unit tests.

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic LGTM, but new config key needs to be added to ozone-default.xml, too.

@elek
Copy link
Member

elek commented Aug 24, 2020

Green build + approval. Will merge this after a new build.

@bshashikant
Copy link
Contributor Author

This needs some more changes and i will be updating it very soon.

@bshashikant
Copy link
Contributor Author

@nandakumar131 @ChenSammi can you plz review?

Copy link
Contributor

@GlenGeng-awx GlenGeng-awx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It give Ozone some possibility to handle heterogenous machines.

Copy link
Contributor

@GlenGeng-awx GlenGeng-awx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. just several inline comments. Thanks for the work!

@nandakumar131
Copy link
Contributor

+1, LGTM.

@nandakumar131 nandakumar131 merged commit f8a62d6 into apache:master Oct 5, 2020
errose28 pushed a commit to errose28/ozone that referenced this pull request Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants