HDDS-2444. Remove server side dependencies from ozonefs jar files #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think we can remove the change added in HDDS-2427 right?
As now ozone-common does not bring in hdds-framework and hadoop-hdds-container-service.
Right, it's not required any more. I added the removal to this patch. |
bharatviswa504
approved these changes
Nov 13, 2019
|
/retest |
|
+1. From me too. There is a Rat Check failure. You can fix that push and commit. |
dineshchitlangia
requested changes
Nov 19, 2019
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestOMStorage.java
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestOMStorage.java
Outdated
Show resolved
Hide resolved
Revert "HDDS-2427. Exclude webapps from hadoop-ozone-filesystem-lib-current uber jar" This reverts commit 6a450fb.
|
Thanks @bharatviswa504, @anuengineer and @dineshchitlangia the review. The comments are addressed and last build show that the rat is fine. Acceptance tests are unrelated and will be fixed by #282. I will merge this patch soon... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
During the review of HDDS-2427 we found that some of the server side dependencies (container-service, framework) are added to the ozonefs library jars. Server side dependencies should be excluded from the client side to make the client safer and the build faster.
This patch doesn't introduce any new features just a dependency cleanup:
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2444
How was this patch tested?
Compiled and started basic acceptance test (
compose/ozone/test.sh)