HDDS-4102. Normalize Keypath for lookupKey. #1315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharatviswa504
force-pushed
the
HDDS-4017
branch
from
05c2578
to
bf4456b
Compare
bharatviswa504
changed the title
bharatviswa504
requested review from
avijayanhwx,
arp7,
rakeshadr and
mukul1987
rakeshadr
reviewed
Aug 13, 2020
There was a problem hiding this comment.
Thanks @bharatviswa504 for the contribution.
TestOzoneFileSystem#testDeleteCreatesFakeParentDir test is failing with this fix. Please take care this.
|
Thanks the patch @bharatviswa504. Cross-linking my generic questions: https://issues.apache.org/jira/browse/HDDS-4097 |
|
Mistakenly for this PR branch was created in apache repo. @elek @rakeshadr Please have a look into #1328 |
|
Thanks the answers. Just let me clear here: these are not blocking questions, just parallel conversations which is related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When ozone.om.enable.filesystem.paths, OM normalizes path, and stores the Keyname.
Now when user tries to read the file from S3 using the keyName which user has used to create the Key, it will return error KEY_NOT_FOUND
The issue is,
lookupKeyalso need to normalize path, when ozone.om.enable.filesystem.paths is enabled. This is a common API used by S3/FS.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4102
How was this patch tested?
Added a test.