Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-4169. Fix some minor errors in StorageContainerManager.md #1367

Merged
merged 5 commits into from Sep 3, 2020

Conversation

cku328
Copy link
Contributor

@cku328 cku328 commented Aug 31, 2020

What changes were proposed in this pull request?

Fixed typo and removed duplicate title bar.

What is the link to the Apache JIRA

https://issues.apache.org/jira/projects/HDDS/issues/HDDS-4169

How was this patch tested?

It's not necessary.

Copy link
Member

@cxorm cxorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cku328 for the fix.
The work looks good to me, +1.

@amaliujia
Copy link
Contributor

Thanks! LGTM

@cxorm
Copy link
Member

cxorm commented Sep 2, 2020

The failed build-branch / unit (pull_request) seems not related the patch.
Let's commit it again.

@cku328
Copy link
Contributor Author

cku328 commented Sep 2, 2020

Thanks @cxorm & @amaliujia for the review.
Now the CI check has passed.

@cxorm cxorm merged commit b58054e into apache:master Sep 3, 2020
@cxorm
Copy link
Member

cxorm commented Sep 3, 2020

Thank you @amaliujia for reviewing this PR and @cku328 for contributing it.

rakeshadr pushed a commit to rakeshadr/hadoop-ozone that referenced this pull request Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants