HDDS-4204. upgrade docker environment does not work with KEEP_RUNNING=true #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaliujia
reviewed
Sep 3, 2020
| @@ -26,7 +26,6 @@ export COMPOSE_DIR | |||
| export OZONE_VOLUME | |||
|
|
|||
| mkdir -p "${OZONE_VOLUME}"/{dn1,dn2,dn3,om,recon,s3g,scm} | |||
| mkdir -p "${OZONE_VOLUME}/debug" | |||
There was a problem hiding this comment.
/debug is leftover means it is unused now?
There was a problem hiding this comment.
Yes. I had added it for a debug container while trying to find out the cause of permission problems in GitHub Actions (it was working fine locally). I removed the container in the final version, but forgot about the directory.
|
Thanks @amaliujia for the review, and @elek for reviewing and committing it. |
llemec
pushed a commit
to llemec/hadoop-ozone
that referenced
this pull request
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Ozone
upgradetest fails if run withKEEP_RUNNING=true. The variable is applied to both runs (pre- and post-upgrade), but pre-upgrade containers should be stopped regardless, since they will be replaced by the new ones.Also remove leftover
debugdirectory creation.https://issues.apache.org/jira/browse/HDDS-4204
How was this patch tested?
Tested locally:
Regular CI:
https://github.com/adoroszlai/hadoop-ozone/runs/1067273739