HDDS-2461. Logging by ChunkUtils is misleading #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
approved these changes
Nov 12, 2019
...ner-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/helpers/ChunkUtils.java
Outdated
Show resolved
Hide resolved
adoroszlai
reviewed
Nov 12, 2019
Comment on lines
-45
to
-46
| private static final Logger LOG = LoggerFactory.getLogger( | ||
| ChunkManagerDummyImpl.class); |
There was a problem hiding this comment.
Sorry, I didn't notice this one earlier: we should keep this, since writeChunk uses it. (If removed it will use the one inherited from ChunkManagerImpl, resulting in wrong class name in log message.)
There was a problem hiding this comment.
Yes, thanks. And the LOG should be private in ChunkManagerImpl to avoid such mistakes.
|
Thank You @elek for the contribution and @adoroszlai for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
During a k8s based test I found a lot of log message like:
I was very surprised as at
ChunkManagerImpl:209there was no related lines.It turned out that it's logged by
ChunkUtilsbut it's used the logger ofChunkManagerImpl.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2461
How was this patch tested?
I deployed a new version from Ozone to the kubernetes cluster. But I also added a new test method TestChunkUtil to have at least one unit test method which uses the logger.