Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDDS-2460: Default checksum type is wrong in description #150

Closed
wants to merge 1 commit into from
Closed

HDDS-2460: Default checksum type is wrong in description #150

wants to merge 1 commit into from

Conversation

snemuri
Copy link
Contributor

@snemuri snemuri commented Nov 13, 2019

What changes were proposed in this pull request?

Updated Default checksum type to CRC32 in the description.

What is the link to the Apache JIRA

HDDS-2460

@adoroszlai
Copy link
Contributor

/retest

adoroszlai
adoroszlai approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @snemuri.

elek
elek approved these changes Nov 13, 2019
View reviewed changes
Copy link
Member

@elek elek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Thanks the fix @snemuri
It's definitely CRC32 in the code.l

@elek elek closed this in 2211d63 Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elek elek elek approved these changes

@adoroszlai adoroszlai adoroszlai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@snemuri @adoroszlai @elek