Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDDS-2478. Sonar : remove temporary variable in XceiverClientGrpc sendCommand #165

Merged
merged 1 commit into from Nov 14, 2019
Merged

HDDS-2478. Sonar : remove temporary variable in XceiverClientGrpc sendCommand #165

merged 1 commit into from Nov 14, 2019

Conversation

supratimdeka
Copy link
Contributor

https://issues.apache.org/jira/browse/HDDS-2478

issues reported via Sonar static analysis.

adoroszlai
adoroszlai approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of issue would be great for newbie Jiras.

@anuengineer anuengineer merged commit e350aef into apache:master Nov 14, 2019
@anuengineer
Copy link
Contributor

This kind of issue would be great for newbie Jiras.

I agree, but there are 188 issues that is reported against Ozone just by running static analysis.
Once we run tests and do run time based measures it will be far more. So it is open to all newbies, but in this case the work load is so much that I think all of us will have to pitch in if want to make the code clean and switch this tool as a CI gate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adoroszlai adoroszlai adoroszlai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@supratimdeka @anuengineer @adoroszlai