HDDS-2247. Delete FileEncryptionInfo from KeyInfo when a Key is deleted #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration failure is related. I will update the PR to fix it. |
|
Verified the failures are unrelated to patch. |
|
Change LGTM, +1. Thanks @dineshchitlangia for the patch. |
xiaoyuyao
approved these changes
Nov 18, 2019
|
Thank You @dineshchitlangia for the contribution and @xiaoyuyao for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As part of HDDS-2174 we are deleting GDPR Encryption Key on delete file operation.
However, if KMS is enabled, we are skipping GDPR Encryption Key approach when writing file in a GDPR enforced Bucket.
In such scenario, when KMS is enabled & GDPR enforced on a bucket, if user deletes a file, we should delete the FileEncryptionInfo from KeyInfo, before moving it to deletedTable, else we cannot guarantee Right to Erasure.
Changes proposed:
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2247
How was this patch tested?
New test contributed as part of the PR