Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-2302. Manage common pom versions in one common place #21

Closed
wants to merge 2 commits into from

Conversation

elek
Copy link
Member

@elek elek commented Oct 14, 2019

What changes were proposed in this pull request?

Some of the versions (eg. ozone.version, hdds.version, ratis.version) are required for both ozone and hdds subprojects. As we have a common pom.xml it can be safer to manage them in one common place at the root pom.xml instead of managing them multiple times.

I would move some of the properties to the root pom.xml to make it easier to manage/change them. (For example change the ratis.version at only one place)

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-2302

How this patch can be tested?

Do a normal build.

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like acceptance test is failing because acceptance.sh looks for <ozone.version> in hadoop-ozone/pom.xml:

https://github.com/apache/hadoop-ozone/blob/e722e4d3a73b4eb6f92b678be83ba32590edc085/hadoop-ozone/dev-support/checks/acceptance.sh#L22

Should be changed:

-OZONE_VERSION=$(grep "<ozone.version>" "$DIR/../../pom.xml" | sed 's/<[^>]*>//g'|  sed 's/^[ \t]*//')
+OZONE_VERSION=$(grep "<ozone.version>" "$DIR/../../../pom.xml" | sed 's/<[^>]*>//g'|  sed 's/^[ \t]*//')

or even:

-OZONE_VERSION=$(grep "<ozone.version>" "$DIR/../../pom.xml" | sed 's/<[^>]*>//g'|  sed 's/^[ \t]*//')
+OZONE_VERSION=$(grep "<ozone.version>" pom.xml | sed 's/<[^>]*>//g'|  sed 's/^[ \t]*//')

@anuengineer
Copy link
Contributor

Thank you for the contribution. I have committed this patch to the master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants