Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-2658. Insight log level reset does not work #289

Closed
wants to merge 1 commit into from

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Reset log level to INFO in a shutdown hook instead of finally block.

https://issues.apache.org/jira/browse/HDDS-2658

How was this patch tested?

Tested on compose cluster:

# terminal 1
cd hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozone
docker-compose up -d
docker-compose logs -f om

# terminal 2
cd hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozone
docker-compose exec om bash
ozone insight logs -v om.protocol.client

# terminal 3
cd hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozone
docker-compose exec om ozone freon ockg -F ONE -n 1

Verified that ozone insight shows trace-level log. Stopped ozone insight on terminal 2 (Ctrl-C). Verified that creating another volume is logged in terminal 1 (ie. OM), but debug/trace-level messages are not:

# terminal 3
$ docker-compose exec om ozone freon ockg -F ONE -n 1 -v vol2

# terminal 1
om_1        | 2019-12-03 11:49:49,114 INFO volume.OMVolumeCreateRequest: created volume:vol2 for user:hadoop

https://github.com/adoroszlai/hadoop-ozone/runs/330882658

@elek elek closed this in 7524ee4 Dec 3, 2019
@adoroszlai adoroszlai deleted the HDDS-2658 branch December 3, 2019 17:35
@adoroszlai
Copy link
Contributor Author

Thanks @elek for committing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant