HDDS-2659. KeyValueHandler#handleCreateContainer should log the exception on container creation failure #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyuyao
reviewed
Dec 4, 2019
| @@ -146,6 +146,7 @@ public static ContainerCommandResponseProto logAndReturnError( | |||
| log.info("Operation: {} , Trace ID: {} , Message: {} , Result: {}", | |||
| request.getCmdType().name(), request.getTraceID(), | |||
| ex.getMessage(), ex.getResult().getValueDescriptor().getName()); | |||
| log.error("StorageContainerException Occurred!", ex); | |||
There was a problem hiding this comment.
We already have a log.info just above it with exception message and the result. If more information about the exception is needed, can we consolidate it into the previous message.
There was a problem hiding this comment.
Thanks @xiaoyuyao for the comment.
Updated.
|
Not sure why the checks failed. This patch should not cause it. I have requested a re-run of the tests. |
mukul1987
approved these changes
Dec 12, 2019
|
Thanks @xiaoyuyao, @anuengineer and @bharatviswa504 for the reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Let the
StorageContainerExceptioncause ofKeyValueHandler#handleCreateContainebe logged.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2659
How was this patch tested?
Just build and compile.