HDDS-2910. OzoneManager startup failure with throwing unhelpful excep… #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyuyao
reviewed
Jan 20, 2020
| @@ -335,7 +335,9 @@ private OzoneManager(OzoneConfiguration conf) throws IOException, | |||
| OZONE_OM_USER_MAX_VOLUME + " value should be greater than zero"); | |||
|
|
|||
| if (omStorage.getState() != StorageState.INITIALIZED) { | |||
| throw new OMException("OM not initialized.", | |||
| throw new OMException("OM not initialized, current OM storage state: " + | |||
| omStorage.getState().name() + ". Please check if 'ozone om --init' " | |||
There was a problem hiding this comment.
Thanks @linyiqun for the improvement.
Can we rephrase "Please check if 'ozone om --init' command is executed before starting the OM service." to
Please ensure 'ozone om --init' command is executed once before starting the OM service.",
Otherwise, LGTM.
There was a problem hiding this comment.
Thanks @xiaoyuyao for the review. Have addressed the comment now.
elek
approved these changes
Jan 20, 2020
There was a problem hiding this comment.
+1 Thanks the patch @linyiqun. I very appreciate when usability is improved.
And thanks the review @xiaoyuyao I will merge it soon...
|
Thanks for the review and merge, @elek ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add more helpful message in exception, so that it can quickly guide users how to resolve the issue in starting up OM service.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2910
How was this patch tested?
Just the log message update change, no need to do the test.