Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-2918. Increase timeout of safe-mode exit in acceptance tests #469

Closed
wants to merge 1 commit into from

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

  1. Increase timeout for exit from safe-mode in acceptance tests
  2. Fix lack of logs in case exit from safe-mode times out

https://issues.apache.org/jira/browse/HDDS-2918

How was this patch tested?

Introduced fake error in wait_for_safemode_exit locally, then ran test.sh in ozone env. Verified that containers are stopped and container logs saved after the "error".

https://github.com/adoroszlai/hadoop-ozone/runs/401101722

@adoroszlai adoroszlai self-assigned this Jan 21, 2020
@adoroszlai adoroszlai requested a review from elek January 21, 2020 17:55
@elek
Copy link
Member

elek commented Jan 22, 2020

Thanks the patch @adoroszlai Do you have any example when 90s was not enough?

(I am fine with increasing the timeout anyway, but interested about the build speed and why the initialization takes so long time. I found that the keytab generation is slow but that one will be fixed by #455, I am interested if there are any other problems...)

@adoroszlai
Copy link
Contributor Author

adoroszlai commented Jan 22, 2020

The Jira contains an example and I've seen it quite a few times in various CI runs. But I have no information on the cause due to the log collection problem, nor on how long it would take for SCM to exit safe mode in these cases.

@elek
Copy link
Member

elek commented Jan 23, 2020

Ok. thanks the answer. hadoop31 should be a new, unknown problem. There is no keytab generation file there.

Let me commit this patch anyway...

Copy link
Member

@elek elek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thanks the fix @adoroszlai

@elek elek closed this in 803fa29 Jan 23, 2020
@adoroszlai adoroszlai deleted the HDDS-2918 branch January 23, 2020 10:07
@adoroszlai
Copy link
Contributor Author

Thanks @elek for reviewing and committing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants