HDDS-2926. Intermittent failure in TestRecon due to thread timing. #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @avijayanhwx for suggestions. |
|
UT failure is related will update patch with a fix. |
avijayanhwx
reviewed
Jan 27, 2020
...one/recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/ReconContainerDBProvider.java
Outdated
Show resolved
Hide resolved
|
Thanks for working on this @swagle. The change LGTM, and the test passed locally multiple times. But now there is some conflict in the branch. |
|
LGTM +1. |
adoroszlai
approved these changes
Jan 29, 2020
There was a problem hiding this comment.
Thanks @swagle for updating the patch. Please note that using git merge instead of git rebase for updating to latest master makes reviewing incremental changes easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2926
How was this patch tested?
The integration test passed.