HDDS-2883. Change the default client settings accordingly with change in default chunk size. #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
reviewed
Jan 24, 2020
There was a problem hiding this comment.
Thanks @bharatviswa504 for working on this. Shouldn't the default values be changed in OzoneConfigKeys, too?
… in default chunk size.
bharatviswa504
force-pushed
the
HDDS-2883
branch
from
d6aae59
to
4069612
Compare
Thank You @adoroszlai for the review. Yes, we need to update. Updated in the latest commit. |
bharatviswa504
changed the title
adoroszlai
approved these changes
Feb 3, 2020
|
Thank You @adoroszlai and @arp7 for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This Jira proposes to change the following values
ozone.client.stream.buffer.flush.size - 64MB -> 16MB
ozone.client.stream.buffer.max.size - 128 MB -> 32MB
ozone.scm.chunk.size - 16MB -> 4MB
In this way, the client-side holding buffer size will be reduced, and data is transferred at smaller size intervals.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2883
How was this patch tested?
Multiple teragen tests are run on a 6 node cluster with these values and along changes from HDDS-2920 and HDDS-2921 we have seen teragen completed successfully.