HDDS-3031. OM HA- Client requests get LeaderNotReadyException after OM's restart. #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -164,7 +164,7 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager, | |||
| // Replay implies the response has already been returned to | |||
| // the client. So take no further action and return a dummy | |||
| // OMClientResponse. | |||
| LOG.debug("Replayed Transaction {} ignored. Request: {}", | |||
| LOG.info("Replayed Transaction {} ignored. Request: {}", | |||
There was a problem hiding this comment.
Keeping this log message at info level will flood the log file. It prints the Request body also.
| ozoneManagerDoubleBufferHelper.add(omClientResponse, | ||
| transactionLogIndex)); | ||
| } | ||
|
|
There was a problem hiding this comment.
Missed adding addResponseToDoubleBuffer() here.
|
Thank You @hanishakoneru for the review. |
bharatviswa504
force-pushed
the
HDDS-3031
branch
from
1f09442
to
b09ecce
Compare
|
LGTM. +1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix LeaderNotReady exception which is thrown for write requests after OM restarts.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3031
How was this patch tested?
Deployed on the cluster and tried the scenario. With the PR fix, now able to execute client requests after OM restart.
I will see if I can add UT for this.