HDDS-2648. TestOzoneManagerDoubleBufferWithOMResponse. #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
approved these changes
Feb 25, 2020
There was a problem hiding this comment.
Thanks @bharatviswa504 for the fix. It passed 10/10 runs: https://github.com/adoroszlai/hadoop-ozone/runs/466543332
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix flaky test.
The issue with testDoubleBufferWithMixOfTransactionsParallel is because the lastAppliedIndex can be exactly not equal to total transaction count. This is because in 2 threads executing createBucket
T1- CreateBucket
T2-CreateBucket
T2 got lock first and put in double buffer and updateLastAppliedIndex to 2, and then when T1 executes it updates it to 1. So, just in parallel test checked that it is less than or equal to total transaction count.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2648
How was this patch tested?
This is a test only change.