HDDS-3134. Debug Tool that gives chunk location information given a key. #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sadanand48 Please fix the failing CI issues in this patch. |
elek
changed the title
bshashikant
reviewed
Apr 2, 2020
...-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainerData.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/OzoneAdmin.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/ChunkKeyHandler.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/ChunkKeyHandler.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/ChunkKeyHandler.java
Outdated
Show resolved
Hide resolved
bshashikant
reviewed
Apr 2, 2020
bshashikant
reviewed
Apr 6, 2020
...-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainerData.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/ChunkKeyHandler.java
Outdated
Show resolved
Hide resolved
bshashikant
reviewed
Apr 8, 2020
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/package-info.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/ChunkKeyHandler.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/ChunkKeyHandler.java
Outdated
Show resolved
Hide resolved
bshashikant
approved these changes
Apr 9, 2020
There was a problem hiding this comment.
The changes look good to me but will be holding off committing this until the acceptance tests failures are fixed and have clean CI run.
Please fix the acceptance test as its related.
Start / End / Elapsed: | 20200409 13:50:46.864 / 20200409 13:50:46.865 / 00:00:00.001
KEYWORD ${result} = commonlib . Execute ozone debug chunkinfo ${protocol}${server}/${volume}/bb1/key1 | jq, '.[]'
Start / End / Elapsed:20200409 13:50:46.864 / 20200409 13:50:46.865 / 00:00:00.00113:50:46.865FAILKeyword 'commonlib.Execute' expected 1 argument, got 2.
bshashikant
requested changes
Apr 9, 2020
mukul1987
approved these changes
Apr 15, 2020
There was a problem hiding this comment.
Thanks for the changes @sadanand48, +1 the changes look good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Debug tool to display chunk information given a key.Apart from Chunks ,it also displays information about the container on which the chunks are present and the pipeline info
Non-Verbose output:Verbose Output:What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3134
How was this patch tested?
Included robot tests in ozone-shell.robot