Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-3280. Ozone BaseHTTPServer should honor ozone.security.enabled c… #758

Merged
merged 4 commits into from Apr 7, 2020

Conversation

vivekratnavel
Copy link
Contributor

…onfig

What changes were proposed in this pull request?

  • Base HTTP server should start with SPNEGO username and keytab only if "ozone.security.enabled" and "ozone.security.kerberos.http.enabled" configs are set to true.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-3280

How was this patch tested?

This patch was tested in a cluster with Kerberos and auto-TLS enabled under different configurations:

  • Both "ozone.security.enabled" and "ozone.security.kerberos.http.enabled" set to false
  • "ozone.security.enabled" set to true
  • Both "ozone.security.enabled" and "ozone.security.kerberos.http.enabled" set to true

@vivekratnavel
Copy link
Contributor Author

@xiaoyuyao Please review

Copy link
Contributor

@xiaoyuyao xiaoyuyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two minor comments.

Copy link
Contributor

@xiaoyuyao xiaoyuyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 pending CI.

@xiaoyuyao xiaoyuyao merged commit b0973ff into apache:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants