Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-2352. Client gets internal error instead of volume not found in secure cluster #76

Merged
merged 1 commit into from
Oct 24, 2019

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Let checkAccess propagate original OMException with VOLUME_NOT_FOUND result code instead of new one with INTERNAL_ERROR. This is similar to existing logic for buckets.

https://issues.apache.org/jira/browse/HDDS-2352

How was this patch tested?

Tested original steps to reproduce:

$ cd hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozonesecure
$ docker-compose exec scm bash
$ kinit -kt /etc/security/keytabs/testuser.keytab testuser/scm@EXAMPLE.COM
$ ozone freon ockg -n 1 -t 1
...
2019-10-23 18:52:25,424 [main] INFO       - Creating Volume: vol1, with testuser/scm@EXAMPLE.COM as owner.
2019-10-23 18:52:25,542 [main] INFO       - Creating Bucket: vol1/bucket1, with Versioning false and Storage Type set to DISK and Encryption set to false
...
Successful executions: 1

Also ran ozonesecure acceptance test.

Copy link
Contributor

@dineshchitlangia dineshchitlangia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM, pending CI.
Thanks @adoroszlai for reporting & fixing this.

Copy link
Contributor

@bharatviswa504 bharatviswa504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

@bharatviswa504 bharatviswa504 merged commit 9475d26 into apache:master Oct 24, 2019
@bharatviswa504
Copy link
Contributor

Thank You @adoroszlai for the fix and @dineshchitlangia for the review.

@adoroszlai adoroszlai deleted the HDDS-2352 branch October 24, 2019 06:35
@adoroszlai
Copy link
Contributor Author

Thanks @dineshchitlangia for the prompt review, and @bharatviswa504 for reviewing and merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants