HDDS-3380. MiniOzoneHAClusterImpl#initOMRatisConf will reset the configs and causes for test failures #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igs and causes for test failures
…igs and causes for test failures
…igs and causes for test failures
…igs and causes for test failures
| @@ -470,6 +468,7 @@ public void testCreateFile(OzoneBucket ozoneBucket, String keyName, | |||
| Assert.assertEquals(data, new String(fileContent)); | |||
| } | |||
|
|
|||
| @Ignore("This test failing randomly and triggering HDDS-3465. ` `4qa wq") | |||
There was a problem hiding this comment.
NIT: Remove 4qa wq"
There was a problem hiding this comment.
Damn, somehow I pressed some unwanted chars before commit. I will change it.
| @@ -93,8 +93,7 @@ | |||
| .OZONE_CLIENT_FAILOVER_SLEEP_BASE_MILLIS_DEFAULT; | |||
| import static org.apache.hadoop.ozone.OzoneConfigKeys | |||
| .OZONE_OPEN_KEY_EXPIRE_THRESHOLD_SECONDS; | |||
| import static org.apache.hadoop.ozone.om.exceptions.OMException.ResultCodes.FILE_ALREADY_EXISTS; | |||
| import static org.apache.hadoop.ozone.om.exceptions.OMException.ResultCodes.NOT_A_FILE; | |||
| import static org.apache.hadoop.ozone.om.exceptions.OMException.ResultCodes.*; | |||
There was a problem hiding this comment.
Minor NIT: Do not use *
There was a problem hiding this comment.
I think that was done by Intellij auto.
…igs and causes for test failures
…igs and causes for test failures
| @@ -383,6 +383,7 @@ public MiniOzoneChaosCluster build() throws IOException { | |||
|
|
|||
| DefaultMetricsSystem.setMiniClusterMode(true); | |||
| initializeConfiguration(); | |||
|
|
|||
There was a problem hiding this comment.
NIT: Only space change
| conf.setTimeDuration( | ||
| OMConfigKeys.OZONE_OM_LEADER_ELECTION_MINIMUM_TIMEOUT_DURATION_KEY, | ||
| LEADER_ELECTION_TIMEOUT, TimeUnit.MILLISECONDS); | ||
| conf.set(ScmConfigKeys.OZONE_SCM_CLIENT_ADDRESS_KEY, "127." + |
There was a problem hiding this comment.
NIT: Can we move this to single line
| RATIS_LEADER_ELECTION_TIMEOUT, TimeUnit.MILLISECONDS); | ||
| // If test change the following config values we will respect, | ||
| // otherwise we will set lower timeout values. | ||
| long defaultDuration = OMConfigKeys |
There was a problem hiding this comment.
Formatting is not proper here for these code lines, few of them can fit in a single line.
…igs and causes for test failures
…igs and causes for test failures
umamaheswararao
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…igs and causes for test failures
What changes were proposed in this pull request?
Moved the configs settings only to required test class instead of silently resetting test modified configs. Also took liberty to change assertion from NOT_A_FILE to DIR_NOT_FOUND, which seems correct code.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3380
How was this patch tested?
Ran the TestOzoneManagerHA tests. SnapShot test is passing after fixing resetting issue.