HDDS-3400. Extract test utilities to separate module #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elek
approved these changes
Apr 17, 2020
There was a problem hiding this comment.
+1
Thanks for the cleanup @adoroszlai
It opens the door to do some follow-up tasks and remove dependencies on hadoop-common/test-jar and use our own test utils...
Will merge it soon...
|
Thanks @elek for reviewing and committing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Create
hadoop-hdds/test-utilsmodule for test utilities (eg.GenericTestUtilsandLambdaTestUtils). This should not depend on any other HDDS/Ozone modules: the goal is to be able to use test listeners defined in this module (currently onlyTimedOutTestsListener) in all other modules.https://issues.apache.org/jira/browse/HDDS-3400
How was this patch tested?
CI:
https://github.com/adoroszlai/hadoop-ozone/runs/592403416
Applied the addition of listener from #813, verified that no
ClassNotFoundExceptionhappens.