Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-3463. Refactor OFSPath to adapt to master branch #847

Merged
merged 1 commit into from Apr 22, 2020

Conversation

smengcl
Copy link
Contributor

@smengcl smengcl commented Apr 20, 2020

What changes were proposed in this pull request?

Refactor OFSPath since master branch removed some dependencies on apache common: details in #822 description.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-3463

How was this patch tested?

Simply run the existing tests.

(cherry picked from commit 1f4b0e1de645737a80a026124095a99c2a5ae240)
@smengcl smengcl changed the base branch from master to HDDS-2665-ofs April 20, 2020 18:34
@smengcl smengcl requested a review from xiaoyuyao April 20, 2020 18:36
Copy link
Contributor

@arp7 arp7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@smengcl
Copy link
Contributor Author

smengcl commented Apr 20, 2020

Thanks @arp7 for the review.

Just to play safe I have cherry-picked HDDS-3456 onto another branch just to run the PR checks: https://github.com/smengcl/hadoop-ozone/commits/HDDS-3463-run-test-with-HDDS-3456

expect green in the run: https://github.com/smengcl/hadoop-ozone/runs/603501816

then I will merge this PR.

@smengcl
Copy link
Contributor Author

smengcl commented Apr 22, 2020

Too many flaky tests in the dev branch :) Most of which are addressed in master branch I believe:

1st run: it-client failed, the rest passed.
2nd run: it-ozone failed, the rest passed.
3rd run: it-freon failed, the rest passed.
4th run: in progress.

At this point I can conclude that the test has passed combining the results above. I'm merging this commit.

@smengcl smengcl merged commit 8356a4a into apache:HDDS-2665-ofs Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants