HDDS-3549. TestKeyInputStream#testSeek fails intermittently. #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshashikant
previously approved these changes
May 6, 2020
adoroszlai
reviewed
May 7, 2020
There was a problem hiding this comment.
Thanks @lokeshj1703 for working on this. Renaming the methods to clarify their difference is a good change. But I don't think the mismatch causes the test failure, both metrics should be 0 at that point.
...ne/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestKeyInputStream.java
Show resolved
Hide resolved
bshashikant
reviewed
May 7, 2020
elek
approved these changes
May 7, 2020
There was a problem hiding this comment.
+1 Thanks @lokeshj1703 fix it.
I propose to commit this patch and fix the other (real?) problem in a separated Jira, if you agree (@bshashikant , @adoroszlai ) as this would fix intermittency in our tests immediately.
adoroszlai
approved these changes
May 7, 2020
|
+1 to commit this. Do we have a separate follow up JIRA? |
|
Filed https://issues.apache.org/jira/browse/HDDS-3578 to fix the other issue. |
mukul1987
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Assert.assertEquals(readChunkCount, metrics .getContainerOpsMetrics(ContainerProtos.Type.ReadChunk));The PR now compares the correct metric i.e. getContainerOpCountMetrics.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3549
How was this patch tested?
The patch fixes a unit test.