HDDS-3602. Fix KeyInputStream by adding a timeout exception. #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dineshchitlangia
approved these changes
May 18, 2020
There was a problem hiding this comment.
+1 LGTM.
Thanks @mukul1987 for the contribution and also removing the unused method/variable.
|
Sorry for being late: can you please explain how adding a timeout fixes the test? |
smengcl
added a commit
to smengcl/hadoop-ozone
that referenced
this pull request
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This tests adds a timeout to KeyInputStream
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3602
How was this patch tested?
Tested by running KeyInputStream