HDDS-3607. Lot of warnings at DN startup. #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukul1987
approved these changes
May 18, 2020
|
/retest |
|
/retest |
|
Hmm... there were an integration test failure that was not related (usual timeout we see in integration tests), I am unsure how to re-initiate testing, but it does not seem to work... :) |
sodonnel
reviewed
May 18, 2020
...-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/BlockManagerImpl.java
Outdated
Show resolved
Hide resolved
|
/retest |
|
@fapifta Thanks for working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The log message which is at WARN level before the PR, is printed for every edit in the raft log since the last snapshot during DataNode startup, as we replay the edits, we don't need to spam with this many warnings, especially as this is part of normal operations. The proposal is to change it to DEBUG level.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3607
How was this patch tested?
No tests were done, seems to be too trivial to be wrong :)