HDDS-3624. Improve error message when GC parameters are not set. #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dineshchitlangia
approved these changes
May 20, 2020
There was a problem hiding this comment.
+1 LGTM @bharatviswa504 thanks for improving the messaging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Improve the message printed to console when starting services.
"No '-XX:...' jvm parameters are used. Adding safer GC settings to the HADOOP_OPTS"
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3624
How was this patch tested?
Tested it with pseudo deployed cluster.
Now with this PR message looks like below.