HDDS-3673. Version information not printed correctly in SCM WebUI. #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
reviewed
May 28, 2020
There was a problem hiding this comment.
Thanks @flirmnave for fixing this issue. Similar change (the one suggested inline) is also included in #869. I would be fine with merging this one first so that you get credit for your contribution, and then rebasing my PR to get this fix.
Co-authored-by: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com>
|
Thanks @adoroszlai for reviewing and I change it. |
adoroszlai
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add property in pom so that can get correct version information.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3673
How was this patch tested?
Run on local docker-compose.
