Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-3676. Display datanode uuid into the printTopology command output #981

Merged
merged 2 commits into from Jun 2, 2020

Conversation

maobaolong
Copy link
Member

@maobaolong maobaolong commented May 28, 2020

What changes were proposed in this pull request?

Sorry to the previous changes HDDS-3606, it is useful, but i have to do some other efforts to distinguish the datanodes in same node, display the uuid of each datanode can make more sense.

What is the link to the Apache JIRA

Display datanode uuid into the printTopology command output

How was this patch tested?

➜  ozone-0.6.0-SNAPSHOT git:(factor2) ✗ bin/ozone admin printTopology
State = HEALTHY
 a33b587b-5f94-4bb5-8ace-6650cbf201ad/127.0.0.1(localhost):RATIS=51134,STANDALONE=51135    /default-rack
 e8b3bf0f-9e77-4314-87dc-85cf51f8c579/127.0.0.1(localhost):RATIS=51072,STANDALONE=51073    /default-rack
 46589563-74c1-438c-b267-c3dc4e6ad1e1/127.0.0.1(localhost):RATIS=51103,STANDALONE=51104    /default-rack
 67d4b200-85fc-4e10-a9eb-65ce2253d4d0/127.0.0.1(localhost):RATIS=51089,STANDALONE=51090    /default-rack

Now, i can easy to distinguish the datanodes.

Copy link
Contributor

@xiaoyuyao xiaoyuyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor suggestion: can we add a CLI argument to make this optional? In most cases, hostname, ip address should be sufficient.

@maobaolong
Copy link
Member Author

@xiaoyuyao Thank you for your review, i add a new option --full to make the full node information optional. PTAL.

Copy link
Contributor

@xiaoyuyao xiaoyuyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1.

@xiaoyuyao xiaoyuyao merged commit a0c7370 into apache:master Jun 2, 2020
isahkemat pushed a commit to isahkemat/hadoop-ozone that referenced this pull request Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants