[SUBMARINE-192] Submarine workbench server daemon shell script #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiwq
reviewed
Sep 28, 2019
bin/common.sh
Outdated
|
|
||
| WORKBENCH_CLASSPATH+=":${SUBMARINE_CONF_DIR}" | ||
|
|
||
| function addEachJarInDir(){ |
There was a problem hiding this comment.
Refer the Google Style (Function Names), it's' not acceptable.
| echo "${WORKBENCH_NAME} is restarting" >> "${WORKBENCH_LOGFILE}" | ||
| stop | ||
| start | ||
| ;; |
There was a problem hiding this comment.
What's the difference between reload and start command?
There was a problem hiding this comment.
No different, So i delete reload commond.
bin/workbench-daemon.sh
Outdated
| } | ||
|
|
||
| function foundWorkbenchServerPid() { | ||
| process=WorkbenchServer; |
There was a problem hiding this comment.
Suggested change
| process=WorkbenchServer; | |
| process='WorkbenchServer'; |
bin/workbench-daemon.sh
Outdated
|
|
||
| function foundWorkbenchServerPid() { | ||
| process=WorkbenchServer; | ||
| RUNNING_PIDS=$(ps x | grep $process | grep -v grep | awk '{print $1}'); |
There was a problem hiding this comment.
Suggested change
| RUNNING_PIDS=$(ps x | grep $process | grep -v grep | awk '{print $1}'); | |
| RUNNING_PIDS=$(ps x | grep ${process} | grep -v grep | awk '{print $1}'); |
|
@jiwq , thank you advise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Increase the Submarine workbench server daemon script,
Support to start, stop, restart the submarine workbench server through
submarine-daemon.shWhat type of PR is it?
[Feature]
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: