Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-24035: Add Jenkinsfile for branch-2.3 #1398

Merged
merged 13 commits into from Sep 24, 2020

Conversation

sunchao
Copy link
Member

@sunchao sunchao commented Aug 12, 2020

What changes were proposed in this pull request?

Enable precommit tests for github PR against branch-2.3.

Why are the changes needed?

Adding a new Jenkinsfile for the repo. This is almost the same file used in the master branch, except changing timeout from 6 to 12 hours.

Does this PR introduce any user-facing change?

No

How was this patch tested?

N/A

@sunchao sunchao changed the title Branch 2.3 jenkinsfile HIVE-24035: Add Jenkinsfile for branch-2.3 Aug 12, 2020
@sunchao
Copy link
Member Author

sunchao commented Aug 18, 2020

@kgyrtkirk the jenkins job is just taking way too long to run - I've changed the threshold to 36 hours and it still timed out. I'm seeing some errors like:

Cannot contact hive-precommit-pr-1398-7-s1hnr-sxk50-z5v6w: hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@59e81d65:JNLP4-connect connection from 10.0.1.14/10.0.1.14:41634": Remote call on JNLP4-connect connection from 10.0.1.14/10.0.1.14:41634 failed. The channel is closing down or has closed down

which seems like some infra issue is going on. Curious if you have any clue and suggestions on how to proceed this.

@sunchao
Copy link
Member Author

sunchao commented Aug 25, 2020

kindly ping @kgyrtkirk - wonder if you have any idea on the jenkins issue. Thanks.

@sunchao
Copy link
Member Author

sunchao commented Sep 14, 2020

@kgyrtkirk it is indeed surefire issue - after upgrading to 3.0.0-M4 the issue was resolved and each pod was able to only run tests assigned to it. The job seems still timed out though since one pod was assigned TestMiniLlapLocalCliDriver which seems to be very slow.

Could you take another look? I'm not sure if it is easy to solve the timeout issue.

@sunchao
Copy link
Member Author

sunchao commented Sep 17, 2020

kindly ping @kgyrtkirk ~~

@sunchao
Copy link
Member Author

sunchao commented Sep 22, 2020

ping @kgyrtkirk and also @belugabehr

@kgyrtkirk
Copy link
Member

sorry for the late response...I've many things going on

it looks much better now - it seem like the minillap driver have reached the global timeout limit

I think we might want to cherry-pick the qtests profile patch from HIVE-23323 - which (for my biggest surprise) seem to apply cleanly.

@sunchao
Copy link
Member Author

sunchao commented Sep 23, 2020

@kgyrtkirk no worries!

I think we might want to cherry-pick the qtests profile patch from HIVE-23323 - which (for my biggest surprise) seem to apply cleanly.

Yes this applies cleanly. Thanks for the pointer! Let me put it together in this PR and trigger another test run. If this works we can cherry-pick it separately into branch-2.3.

@sunchao
Copy link
Member Author

sunchao commented Sep 23, 2020

@kgyrtkirk the latest run went great and only took 10 hours or so. Could you take another look? Thanks!

@kgyrtkirk
Copy link
Member

That's awesome! I believe most of these failures were already there...
I think we can merge these changes as it will enable branch-2.3 to run tests!

@sunchao
Copy link
Member Author

sunchao commented Sep 24, 2020

Thanks @kgyrtkirk for all the help! I'll cherry-pick HIVE-23323 separately and commit it to branch-2.3 first (to keep a clean git history). Then I'll exclude it from this PR and merge. Does it sound good to you?

@kgyrtkirk
Copy link
Member

sounds great!

@sunchao
Copy link
Member Author

sunchao commented Sep 24, 2020

Merged. Thanks again @kgyrtkirk !

szlta pushed a commit to szlta/hive that referenced this pull request Oct 1, 2020
(cherry picked from commit 940ee46)

Change-Id: I5d7bc5b63f87dd3c9ed4cfa547d93b2c2dd64c1a
@sunchao sunchao deleted the branch-2.3-jenkinsfile branch October 9, 2020 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants