Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-26896 : Test fixes for lineage3.q and load_static_ptn_into_bucketed_table.q #3901

Closed
wants to merge 3 commits into from

Conversation

amanraj2520
Copy link
Contributor

@amanraj2520 amanraj2520 commented Jan 2, 2023

These tests were fixed in branch-3.1 as part of Hive 3.1.3 release therefore backporting the same in branch-3. Commit ID : 9fef6b4

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Copy link
Contributor

@cnauroth cnauroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @amanraj2520 . The JIRA issue mentions that this is a backport. For reference, could you please link to the original JIRA issue/commit that contained the fix? Thanks!

@amanraj2520
Copy link
Contributor Author

Hi @cnauroth @abstractdog @zabetak This fix went int branch-3.1 without any JIRA created. If you search "Test fixes for lineage3.q and load_static_ptn_into_bucketed_table.q" on branch-3.1 commits. You will find this commit. Attaching the commit id : 9fef6b4 FYI. Do I need to do anything else? If not can we merge this PR.

Copy link
Contributor

@zabetak zabetak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lineage3 test does not seem to run on branch-3 so the summary and changes are bit misleading.

$ wget -qnv http://ci.hive.apache.org/job/hive-precommit/job/branch-3/12/testReport/api/json -O - | jq '.suites[].cases[] | {className, name, status} | select(.name | match("lineage","load_static"))'
{
  "className": "org.apache.hadoop.hive.cli.split7.TestCliDriver",
  "name": "testCliDriver[lineage1]",
  "status": "PASSED"
}
{
  "className": "org.apache.hadoop.hive.cli.split7.TestCliDriver",
  "name": "testCliDriver[load_static_ptn_into_bucketed_table]",
  "status": "FAILED"
}

Please update JIRA and PR accordingly.

@amanraj2520
Copy link
Contributor Author

amanraj2520 commented Jan 9, 2023

@zabetak lineage3 would run after this #3859 is merged. I had checked it in a sample branch after merging this change. Currently the testCliDriver is not running properly because of netty issues.

@zabetak
Copy link
Contributor

zabetak commented Jan 9, 2023

@amanraj2520 OK then we should wait for #3859 to get in before merging this change.

@amanraj2520
Copy link
Contributor Author

@zabetak Yes we can wait. I have no issue in that. In fact its better that way. But since this change went in branch-3.1 from where Hive-3.1.3 was cut (also in Hive-3.1.3 this commit is present), I was thinking that we can merge this.

@amanraj2520
Copy link
Contributor Author

Hi @zabetak Can you please review and merge this. http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-3929/2/tests You can find the failing tests in the latest branch-3 PR run

@amanraj2520
Copy link
Contributor Author

@zabtek can you please approve this and merge.

@zabetak
Copy link
Contributor

zabetak commented Jan 16, 2023

Hey @amanraj2520, I will merge this once I see that the two tests mentioned here are:

  1. failing on the last precommit run in branch-3
  2. not failing on the last precommit run in this PR.

lineage3 seems to pass here http://ci.hive.apache.org/job/hive-precommit/job/branch-3/15

@amanraj2520
Copy link
Contributor Author

@zabetak I cannot find any test case where lineage3 failed. I will revert the lineage3 fix and rename this PR.

@amanraj2520
Copy link
Contributor Author

@zabetak Modified it. Kindly review this.

zabetak pushed a commit that referenced this pull request Jan 17, 2023
@zabetak zabetak closed this Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants