Skip to content

Commit

Permalink
fewer boxing conversions needed when stored as an object
Browse files Browse the repository at this point in the history
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1571387 13f79535-47bb-0310-9956-ffa450edef68
  • Loading branch information
sebbASF committed Feb 24, 2014
1 parent da69db6 commit 92448db
Showing 1 changed file with 6 additions and 6 deletions.
Expand Up @@ -81,11 +81,11 @@ public final class OSGiProxyConfiguration implements ProxyConfiguration {

private static final String[] PROPERTYDEFAULT_PROXY_EXCEPTIONS = new String[]{"localhost", "127.0.0.1"};

private boolean enabled;
private Boolean enabled = Boolean.FALSE; // fewer boxing conversions needed when stored as an object

private String hostname;

private int port;
private Integer port = Integer.valueOf(0); // fewer boxing conversions needed when stored as an object

private String username;

Expand All @@ -95,7 +95,7 @@ public final class OSGiProxyConfiguration implements ProxyConfiguration {

@Override
public boolean isEnabled() {
return enabled;
return enabled.booleanValue();
}

@Override
Expand All @@ -105,7 +105,7 @@ public String getHostname() {

@Override
public int getPort() {
return port;
return port.intValue();
}

@Override
Expand All @@ -124,9 +124,9 @@ public String[] getProxyExceptions() {
}

public void update(final Dictionary<String, Object> config) {
enabled = to(config.get(PROPERTYNAME_PROXY_ENABLED), boolean.class, PROPERTYDEFAULT_PROXY_ENABLED).booleanValue();
enabled = to(config.get(PROPERTYNAME_PROXY_ENABLED), boolean.class, PROPERTYDEFAULT_PROXY_ENABLED);
hostname = to(config.get(PROPERTYNAME_PROXY_HOSTNAME), String.class, PROPERTYDEFAULT_PROXY_HOSTNAME);
port = to(config.get(PROPERTYNAME_PROXY_PORT), int.class, PROPERTYDEFAULT_PROXY_PORT).intValue();
port = to(config.get(PROPERTYNAME_PROXY_PORT), int.class, PROPERTYDEFAULT_PROXY_PORT);
username = to(config.get(PROPERTYNAME_PROXY_USERNAME), String.class, PROPERTYDEFAULT_PROXY_USERNAME);
password = to(config.get(PROPERTYNAME_PROXY_PASSWORD), String.class, PROPERTYDEFAULT_PROXY_PASSWORD);
proxyExceptions = to(config.get(PROPERTYNAME_PROXY_EXCEPTIONS), String[].class, PROPERTYDEFAULT_PROXY_EXCEPTIONS);
Expand Down

0 comments on commit 92448db

Please sign in to comment.