Skip to content

Commit

Permalink
* modules/generators/mod_cgi.c (cgi_handler): Fix possible segfaults
Browse files Browse the repository at this point in the history
in CGI bucket methods if invoked from a subrequest.

PR: 31247


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@105250 13f79535-47bb-0310-9956-ffa450edef68
  • Loading branch information
notroj committed Sep 22, 2004
1 parent 07b2af2 commit bbeb051
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion modules/generators/mod_cgi.c
Expand Up @@ -905,7 +905,10 @@ static int cgi_handler(request_rec *r)
apr_file_pipe_timeout_set(script_in, 0);
apr_file_pipe_timeout_set(script_err, 0);

b = cgi_bucket_create(r, script_in, script_err, c->bucket_alloc);
/* if r is a subrequest, ensure that the bucket only references
* r->main, since it may last longer than the subreq. */
b = cgi_bucket_create(r->main ? r->main : r, script_in, script_err,
c->bucket_alloc);
#else
b = apr_bucket_pipe_create(script_in, c->bucket_alloc);
#endif
Expand Down

0 comments on commit bbeb051

Please sign in to comment.