Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-5205] Support Flink 1.16.0 #7584

Merged
merged 1 commit into from Jan 5, 2023

Conversation

stayrascal
Copy link
Contributor

@stayrascal stayrascal commented Dec 30, 2022

Change Logs

  • support flink 1.16.0
  • Based on PR
    • copy the existing adapters from hudi-flink1.15.x to hudi-flink1.16.x
    • Add new adapters StreamWriteOperatorCoordinatorAdapter & SortOperatorGenAdapter in each flink module
    • add flink1.16 profile in ci matrix

Impact

Low

Risk level (write none, low medium or high below)

Low

Documentation Update

the official documents need to be updated

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@stayrascal stayrascal force-pushed the support-flink-1.16 branch 2 times, most recently from a1b8507 to 1e9fa1c Compare December 30, 2022 08:02
@danny0405 danny0405 self-assigned this Jan 3, 2023
@danny0405 danny0405 added the flink Issues related to flink label Jan 3, 2023
.github/workflows/bot.yml Show resolved Hide resolved

/**
* Bridge class for shaded guava clazz {@code StreamWriteOperatorCoordinator}.
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename the clazz to OperatorCoordinatorAdapter, the license header is also missing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it.

@danny0405 danny0405 changed the title [HUDI-5205] support flink 1.16.0 [HUDI-5205] Support Flink 1.16.0 Jan 3, 2023
@danny0405
Copy link
Contributor

Thanks for the contribution, I have reviewed and applied a patch here:
5205.zip

You can apply the patch with cmd: git apply ${patch_path}
Then force push the branch with cmd: git push ${branch_name} --force.

@rahil-c
Copy link
Contributor

rahil-c commented Jan 3, 2023

@stayrascal @danny0405 Thanks for making this change, just to confirm this is targeted for Hudi 0.13.0?

@stayrascal
Copy link
Contributor Author

stayrascal commented Jan 4, 2023

Thanks for the contribution, I have reviewed and applied a patch here: 5205.zip

You can apply the patch with cmd: git apply ${patch_path} Then force push the branch with cmd: git push ${branch_name} --force.

Thanks a lot for reviewing this PR, will apply this patch.
BTW, there are some IT cases failed by NPE, still need fix the issues later.

@stayrascal
Copy link
Contributor Author

@stayrascal @danny0405 Thanks for making this change, just to confirm this is targeted for Hudi 0.13.0?

Currently, this change is targeted to master branch(0.13.0), but in my case, I will apply this change in old version(0.11.1 or 0.12) once everything passed, is there any concern or blockers about apply this change to older version?

@danny0405
Copy link
Contributor

Thanks for the contribution, I have reviewed again and created another patch:
5205.patch.zip

The tests failed because the JsonRowDataDeserializationSchema is refactorted where the #open method must be called for some JSON infrustructures initialization.

@stayrascal stayrascal force-pushed the support-flink-1.16 branch 4 times, most recently from 214fa61 to 08b4f6d Compare January 4, 2023 09:30
@hudi-bot
Copy link

hudi-bot commented Jan 4, 2023

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Copy link
Contributor

@danny0405 danny0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@melin
Copy link

melin commented Feb 8, 2023

upgrade flink version 1.16.1 @danny0405

fengjian428 pushed a commit to fengjian428/hudi that referenced this pull request Apr 5, 2023
Co-authored-by: wuzhiping <wuzhiping.007@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flink Issues related to flink priority:blocker
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants