Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-5545] Extending support to other special characters #7585

Merged
merged 2 commits into from Jan 13, 2023

Conversation

srikanthjaggari
Copy link
Contributor

@srikanthjaggari srikanthjaggari commented Dec 30, 2022

Change Logs

This fix is to cover issue as follows.

I am working on ingestion with S3 as source by following this blog . But 2nd job(S3EventsHoodieIncrSource) failing with
HoodieException: org.apache.hudi.exception.HoodieException: Path does not exist. In our investigation, we have observed job failing due to encoded characters( these are being added by SQS) in S3 object name.
When we deep dive in Hudi source code , we have observed Hudi decoding them in S3EventsMetaSelector & at the movement only = have handled.
FYI-
Original S3 object : s3://<bucket>/s3_parquet_source_data/s3-test+0+0000061344.parquet
Encoded S3 object: s3://<bucket>/s3_parquet_source_data/s3-test%2B0%2B0000061344.parquet
Note: workflow was running successfully if file name corrected.

Impact

See above.

Risk level

none

Documentation Update

N/A

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@srikanthjaggari srikanthjaggari changed the title Extending support to other special characters [MINOR] Extending support to other special characters Dec 30, 2022
@nsivabalan
Copy link
Contributor

there were some check style issues, fixed and pushed them

@apache apache deleted a comment from hudi-bot Jan 12, 2023
@yihua
Copy link
Contributor

yihua commented Jan 12, 2023

@srikanthjaggari Thanks for the fix! Since the Slack message is not going to be visible after 90 days, I updated the description with your message for clarity.

@yihua yihua added priority:critical production down; pipelines stalled; Need help asap. hudistreamer issues related to Hudi streamer (Formely deltastreamer) labels Jan 12, 2023
@yihua yihua changed the title [MINOR] Extending support to other special characters [HUDI-5545] Extending support to other special characters Jan 12, 2023
@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@yihua yihua merged commit 70d450e into apache:master Jan 13, 2023
fengjian428 pushed a commit to fengjian428/hudi that referenced this pull request Jan 31, 2023
fengjian428 pushed a commit to fengjian428/hudi that referenced this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hudistreamer issues related to Hudi streamer (Formely deltastreamer) priority:critical production down; pipelines stalled; Need help asap.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants