Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature request] Improve integration test reliance on docker #637

Open
kevinjqliu opened this issue Apr 19, 2024 · 4 comments
Open

[feature request] Improve integration test reliance on docker #637

kevinjqliu opened this issue Apr 19, 2024 · 4 comments

Comments

@kevinjqliu
Copy link
Collaborator

Feature Request / Improvement

It would be nice to eliminate the sleep 10 and instead use health checks for the underlying containers.

iceberg-python/Makefile

Line 43 in 188e2c4

sleep 10

The sleep here is a proxy for waiting for REST/HMS services to be available.
@kevinjqliu kevinjqliu mentioned this issue Apr 19, 2024
Merged
@AronsonDan
Copy link

@kevinjqliu Did you guys consider using testcontainers?

@kevinjqliu
Copy link
Collaborator Author

@AronsonDan I have not heard of this before. I'll take a look, thank you!

@AronsonDan
Copy link

Would love to give a hand setting up testconteiners using pytest

@kevinjqliu
Copy link
Collaborator Author

@AronsonDan please do! Feel free to tag me or reach out with any questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevinjqliu @AronsonDan